Assessments API (Azure Security Center) by Eitan-Lev · Pull Request #7678 · Azure/azure-rest-api-specs

Eitan-Lev · 2019-10-31T08:56:55Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-10-31T08:57:51Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8709

azuresdkci · 2019-10-31T08:58:39Z

Can one of the admins verify this patch?

AutorestCI · 2019-10-31T08:59:43Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6454

Eitan-Lev · 2019-11-12T12:04:07Z

Hi @jhendrixMSFT, can you please review the PR?

jhendrixMSFT · 2019-11-12T15:03:45Z

@Eitan-Lev I'm waiting for the ARM review since their feedback can change the shape of the API.

ravbhatnagar

@Eitan-Lev - just one comment

...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json

specification/security/resource-manager/common/v1/types.json

azure-pipelines · 2019-12-04T21:50:30Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-04T21:52:42Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 746dca8 with merge commit 5738515. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/54: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 24 Dec 2019 23:13:38 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C1:4285:B3E5A1:1CE0258:5E029BA1","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4990","x-ratelimit-reset":"1577232813","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_arm-security@7678","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}

️✔️@azure/arm-security [Logs] [Release SDK Changes]

azure-arm-security-1.2.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
[npmPack] created ./dist/arm-security.js in 957ms

openapi-sdkautomation · 2019-12-04T21:52:46Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 746dca8 with merge commit 5738515. SDK Automation 13.0.17.20191213.4
️✔️preview/security/mgmt/v1.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v1.0.zip
️✔️preview/security/mgmt/v2.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v2.0.zip
️✔️preview/security/mgmt/v3.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v3.0.zip

openapi-sdkautomation · 2019-12-04T21:52:48Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-04T21:52:49Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 746dca8 with merge commit 5738515. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/60: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 24 Dec 2019 23:13:42 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C1:0D97:8F2BF2:180839B:5E029BA5","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4984","x-ratelimit-reset":"1577232813","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-security@7678","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}

️✔️azure-mgmt-security [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

openapi-sdkautomation · 2019-12-04T21:52:52Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 746dca8 with merge commit 5738515. SDK Automation 13.0.17.20191213.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityCenter [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityCenter.1.1.0.nupkg
- Microsoft.Azure.Management.SecurityCenter.1.1.0.snupkg

azure-pipelines · 2019-12-04T21:55:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-04T22:07:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-09T22:55:07Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-09T23:14:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-09T23:34:30Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-17T16:04:34Z

Azure Pipelines successfully started running 1 pipeline(s).

...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json

...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json

specification/security/resource-manager/common/v1/types.json

...icrosoft.Security/preview/2019-01-01-preview/examples/Assessments/PutAssessment_example.json

azure-pipelines · 2019-12-18T09:05:00Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-18T10:03:44Z

Azure Pipelines successfully started running 1 pipeline(s).

pilor

See open comments from previous review as well

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json

azure-pipelines · 2019-12-19T12:50:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-19T13:44:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-19T15:13:02Z

Azure Pipelines successfully started running 1 pipeline(s).

chlahav · 2019-12-22T08:44:44Z

hi @jhendrixMSFT
can you please review?

azuresdkci assigned jhendrixMSFT Oct 31, 2019

azuresdkci requested a review from jhendrixMSFT October 31, 2019 08:58

eliagrady requested a review from chlahav October 31, 2019 09:06

AutorestCI mentioned this pull request Oct 31, 2019

[AutoPR security/resource-manager] Assessments API (Azure Security Center) Azure/azure-sdk-for-go#6205

Closed

chlahav added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 31, 2019

chlahav approved these changes Oct 31, 2019

View reviewed changes

ravbhatnagar reviewed Nov 14, 2019

View reviewed changes

...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json Outdated Show resolved Hide resolved

ravbhatnagar added the ARMChangesRequested label Nov 14, 2019

ryansbenson reviewed Nov 21, 2019

View reviewed changes

This was referenced Dec 3, 2019

[AutoPR security/resource-manager] Assessments API (Azure Security Center) Azure/azure-sdk-for-python#8948

Closed

[AutoPR security/resource-manager] Assessments API (Azure Security Center) Azure/azure-sdk-for-go#6479

Closed

openapi-sdkautomation bot mentioned this pull request Dec 4, 2019

[AutoPR azure-mgmt-security] Assessments API (Azure Security Center) AzureSDKAutomation/azure-sdk-for-python#60

Closed

This was referenced Dec 4, 2019

[AutoPR Microsoft.Azure.Management.SecurityCenter] Assessments API (Azure Security Center) AzureSDKAutomation/azure-sdk-for-net#161

Closed

[AutoPR @azure/arm-security] Assessments API (Azure Security Center) AzureSDKAutomation/azure-sdk-for-js#54

Closed

openapi-sdkautomation bot mentioned this pull request Dec 9, 2019

[AutoPR azure-mgmt-security] Assessments API (Azure Security Center) AzureSDKAutomation/azure-sdk-for-python#87

Closed

This was referenced Dec 9, 2019

[AutoPR Microsoft.Azure.Management.SecurityCenter] Assessments API (Azure Security Center) AzureSDKAutomation/azure-sdk-for-net#194

Closed

[AutoPR @azure/arm-security] Assessments API (Azure Security Center) AzureSDKAutomation/azure-sdk-for-js#103

Closed

pilor suggested changes Dec 17, 2019

View reviewed changes

pilor suggested changes Dec 18, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

Eitan Levin and others added 3 commits December 19, 2019 17:11

Add asessments swagger

acae66d

Add delete option to assessments

ea17d70

Fixing tests

746dca8

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 19, 2019

pilor approved these changes Dec 19, 2019

View reviewed changes

sergey-shandar added the Reassign label Dec 23, 2019

azuresdkci removed the Reassign label Dec 23, 2019

azuresdkci assigned zikalino and unassigned jhendrixMSFT Dec 23, 2019

azuresdkci requested a review from zikalino December 23, 2019 23:14

zikalino approved these changes Dec 24, 2019

View reviewed changes

zikalino merged commit 5738515 into Azure:master Dec 24, 2019

Conversation

Eitan-Lev commented Oct 31, 2019 • edited by chlahav Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Oct 31, 2019

Uh oh!

AutorestCI commented Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Eitan-Lev commented Nov 12, 2019

Uh oh!

jhendrixMSFT commented Nov 12, 2019

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Dec 4, 2019

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

azure-pipelines bot commented Dec 4, 2019

Uh oh!

azure-pipelines bot commented Dec 4, 2019

Uh oh!

azure-pipelines bot commented Dec 9, 2019

Uh oh!

azure-pipelines bot commented Dec 9, 2019

Uh oh!

azure-pipelines bot commented Dec 9, 2019

Uh oh!

azure-pipelines bot commented Dec 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Dec 18, 2019

Uh oh!

azure-pipelines bot commented Dec 18, 2019

Uh oh!

pilor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azure-pipelines bot commented Dec 19, 2019

Uh oh!

azure-pipelines bot commented Dec 19, 2019

Eitan-Lev commented Oct 31, 2019 •

edited by chlahav

Loading

AutorestCI commented Oct 31, 2019 •

edited

Loading

AutorestCI commented Oct 31, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading